[pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard

Lorenz Stechauner l.stechauner at proxmox.com
Tue Oct 19 15:53:58 CEST 2021


Hi,

everything looks and works as expected. No disk/mount point window looks 
broken.

Tested VM/CT creation wizard and adding of disks/mount points afterwards.

Tested-By: Lorenz Stechauner <l.stechauner at proxmox.com>

On 05.10.21 13:28, Dominik Csapak wrote:
> this series is a continuation of my previous multi tab / disk series[0]
>
> Introduces multi disk panels for vm and containers in the wizard.
>
> The UX is modeled after Dominics first attempt, but a very different
> approach code-wise. instead of having a seperate 'data' panel that
> contains the vm config, let the multi disk panel handle that
> and pass it through to the panels below. this way the HDEdit does
> not need a big code-change to get/set the config.
>
> changes from v2:
> * rebase on master (multi tab disk panel already applied)
> * refactor multi disk panel so that we can reuse it for containers
> * implement multi mp panel for container
>
> changes from v1:
> * fixed a bug which prevented the wizard from finishing
> * made the wizard a little wider so that the form field labes are
>    readable
> * added logic to use the ostype to determine the first disk if one
>    deleted all before
>
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-October/050215.html
>
> Dominik Csapak (7):
>    ui: lxc/MPEdit: add updateVMConfig
>    ui: lxc/MPEdit: fire diskidchange event
>    ui: lxc/MPEdit: add selectFree toggle
>    ui: add MultiDiskPanel
>    ui: add lxc/MultiMPEdit and use in lxc/CreateWizard
>    ui: add qemu/MultiHDEdit and use it in the wizard
>    ui: window/Wizard: make it a little wider
>
>   www/manager6/Makefile               |   3 +
>   www/manager6/lxc/CreateWizard.js    |   8 +-
>   www/manager6/lxc/MPEdit.js          |  16 +-
>   www/manager6/lxc/MultiMPEdit.js     |  79 ++++++++
>   www/manager6/panel/MultiDiskEdit.js | 272 ++++++++++++++++++++++++++++
>   www/manager6/qemu/CreateWizard.js   |   7 +-
>   www/manager6/qemu/HDEdit.js         |   9 +-
>   www/manager6/qemu/MultiHDEdit.js    |  62 +++++++
>   www/manager6/window/Wizard.js       |   2 +-
>   9 files changed, 444 insertions(+), 14 deletions(-)
>   create mode 100644 www/manager6/lxc/MultiMPEdit.js
>   create mode 100644 www/manager6/panel/MultiDiskEdit.js
>   create mode 100644 www/manager6/qemu/MultiHDEdit.js
>




More information about the pve-devel mailing list