[pve-devel] applied: [PATCH v3 manager] ceph install: improve ceph install checks during installation

[Thomas Lamprecht]

On 04.10.21 10:02, Aaron Lauterer wrote:
> Adding a flag file during the Ceph installation helps to cover the time
> span in which the binary is already present but the installation not yet
> done.
> 
> The most noticeable effect is that the 'Next' button in the GUI will
> only become active once the installation is actually finished and not
> earlier.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> v2 -> v3 (thanks for the hints):
>  - calling it a flag and moving it to /run
>  - improve file opening / unlinking handling and showing errors
>  - adding more / improving comments
> 
> v1 -> v3: check for plain file and not just existing file
> 
> If the flag file is created before ceph is installed, there is no
> effect. If it is created after Ceph has been installed, the user is
> prompted by the install dialog once more, but apt will be done right
> away.
> 
>  PVE/CLI/pveceph.pm | 12 ++++++++++++
>  PVE/Ceph/Tools.pm  |  4 +++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
>

applied, thanks! I moved the actual file name into a helper method located in
PVE::Ceph::Tools so that there's only a single source of truth for it.
Plus some minor style nits.