[pve-devel] applied: [PATCH v4 http-server 1/1] anyevent: move unlink from http-server to endpoint

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Oct 4 10:16:20 CEST 2021


On 31.08.21 12:16, Lorenz Stechauner wrote:
> any uploaded file has to be deleted by the corrosponding
> endpoint. the file upload was only used by the 'upload to
> storage' feature in pve.
> 
> this change allows the endpoint to delete the file itself,
> making the old and racey`sleep 1` (waiting until the worker
> has opened the file) obsolete.
> 
> this change breaks all pve-manager versions, in which the
> worker does not unlink the temp file itself.
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
>  src/PVE/APIServer/AnyEvent.pm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
>

applied, thanks!

But I actually now let it break libpve-storage-perl (<< 7.0-11) as that should already
avoid all situations where the old code could run.





More information about the pve-devel mailing list