[pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue May 25 15:26:12 CEST 2021
On 25.05.21 15:15, Oguz Bektas wrote:
> for consistency in post_create_hook. still works as expected
>
what's the reason/benefit again?
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
> src/PVE/LXC/Setup/Base.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index d73335b..be41874 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -422,7 +422,7 @@ sub set_user_authorized_ssh_keys {
> $self->ct_modify_file("$home/.ssh/authorized_keys", $ssh_keys, perms => 0700);
> }
>
> -my $randomize_crontab = sub {
> +sub randomize_crontab {
> my ($self, $conf) = @_;
>
> my @files;
> @@ -450,7 +450,7 @@ my $randomize_crontab = sub {
> }
> $self->ct_file_set_contents($filename, $new);
> }
> -};
> +}
>
> sub set_timezone {
> my ($self, $conf) = @_;
> @@ -493,7 +493,7 @@ sub post_create_hook {
>
> $self->template_fixup($conf);
>
> - &$randomize_crontab($self, $conf);
> + $self->randomize_crontab($conf);
>
> $self->set_user_password($conf, 'root', $root_password);
> $self->set_user_authorized_ssh_keys($conf, 'root', $ssh_keys) if $ssh_keys;
>
More information about the pve-devel
mailing list