[pve-devel] [PATCH manager 2/5] ui: panel/IPSet: eslint fixes

Dominic Jäger d.jaeger at proxmox.com
Wed May 19 12:56:19 CEST 2021


Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
---
 www/manager6/panel/IPSet.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 303e518a..94117789 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -22,11 +22,11 @@ Ext.define('PVE.IPSetList', {
     initComponent: function() {
         var me = this;
 
-	if (me.ipset_panel == undefined) {
+	if (typeof me.ipset_panel === 'undefined') {
 	    throw "no rule panel specified";
 	}
 
-	if (me.base_url == undefined) {
+	if (typeof me.ipset_panel === 'undefined') {
 	    throw "no base_url specified";
 	}
 
@@ -143,7 +143,7 @@ Ext.define('PVE.IPSetList', {
 	    ],
 	    listeners: {
 		itemdblclick: run_editor,
-		select: function(sm, rec) {
+		select: function(_, rec) {
 		    var url = me.base_url + '/' + rec.data.name;
 		    me.ipset_panel.setBaseUrl(url);
 		},
@@ -346,7 +346,7 @@ Ext.define('PVE.IPSetGrid', {
 		    metaData.tdCls = 'proxmox-invalid-row';
 		    var html = '<p>' + Ext.htmlEncode(msg) + '</p>';
 		    metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' +
-			html.replace(/\"/g, '"') + '"';
+			html.replace(/"/g, '"') + '"';
 		}
 	    }
 	    return value;
-- 
2.20.1





More information about the pve-devel mailing list