[pve-devel] applied: [PATCH manager] ui: dc: backup: fix job detail search

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 22 11:52:29 CEST 2021


On 22.06.21 10:07, Aaron Lauterer wrote:
> 'for...in array' returns the id in the array but not the value,
> 'for...of array' returns the values.
> 
> Another issue that I ran into was if the property did not exist.

Having something like "another issue fixed with additional changes" is
always a good indicator that it could be a separate patch.

> 
> Checking if the property evaluates to false will catch situations where
> the property does not exist or is null. All other situations where there
> is a value for the name, id or type, should evaluate to true if present
> as they are strings or the VMID.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
>  www/manager6/dc/Backup.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, to both master and stable-6, thanks!





More information about the pve-devel mailing list