[pve-devel] [PATCH manager] ui: dc: backup: fix job detail search

Aaron Lauterer a.lauterer at proxmox.com
Tue Jun 22 10:07:26 CEST 2021

'for...in array' returns the id in the array but not the value,
'for...of array' returns the values.

Another issue that I ran into was if the property did not exist.

Checking if the property evaluates to false will catch situations where
the property does not exist or is null. All other situations where there
is a value for the name, id or type, should evaluate to true if present
as they are strings or the VMID.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
 www/manager6/dc/Backup.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 99401154..6be545ee 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -515,8 +515,8 @@ Ext.define('PVE.dc.BackupDiskTree', {
 				    data = record.parentNode.data;
-				for (const property in ['name', 'id', 'type']) {
-				    if (data[property] === null) {
+				for (const property of ['name', 'id', 'type']) {
+				    if (!data[property]) {
 				    let v = data[property].toString();

More information about the pve-devel mailing list