[pve-devel] [PATCH v2 storage 1/3] status: move unlink from http-server to enpoint

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jul 30 15:13:16 CEST 2021


On 22/07/2021 15:06, Lorenz Stechauner wrote:
> this is the first step in which not the http server removes the
> temporary file, but the worker itself.
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
>  PVE/API2/Storage/Status.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
> index 16581aa..fcf9720 100644
> --- a/PVE/API2/Storage/Status.pm
> +++ b/PVE/API2/Storage/Status.pm
> @@ -480,6 +480,7 @@ __PACKAGE__->register_method ({
>  	    print "command: " . join(' ', @$cmd) . "\n";
>  
>  	    eval { PVE::Tools::run_command($cmd, errmsg => 'import failed'); };
> +	    unlink $tmpfilename or warn "unable to clean up temporory file '$tmpfilename' - $!";

s/temporory/temporary/

>  	    if (my $err = $@) {
>  		unlink $dest;
>  		die $err;
> 






More information about the pve-devel mailing list