[pve-devel] [PATCH v2 storage 2/3] status: remove sleep(1) in file upload

Lorenz Stechauner l.stechauner at proxmox.com
Thu Jul 22 15:06:25 CEST 2021

this racey sleep(1) is only there for legacy reasons: because
we don't use apache anymore and only emulate its behabiour
regarding removing temp files, this is under our own control
now and so we can improve this whole situation.

this change requires a pve-http-server version, in which the
tmpfile gets not automatically removed anymore.

Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
 PVE/API2/Storage/Status.pm | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index fcf9720..9cf6e40 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Status.pm
@@ -488,14 +488,7 @@ __PACKAGE__->register_method ({
 	    print "finished file import successfully\n";
-	my $upid = $rpcenv->fork_worker('imgcopy', undef, $user, $worker);
-	# apache removes the temporary file on return, so we need
-	# to wait here to make sure the worker process starts and
-	# opens the file before it gets removed.
-	sleep(1);
-	return $upid;
+	return $rpcenv->fork_worker('imgcopy', undef, $user, $worker);

More information about the pve-devel mailing list