[pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option

[alexandre derumier]

Le mardi 13 juillet 2021 à 06:41 +0200, Thomas Lamprecht a écrit :
> On 12.07.21 00:48, Alexandre Derumier wrote:
> > allow to register ip to ipam without dns registration.
> > can be used for temp/pending ip for example
> > 
> > Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> > ---
> >  PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++------------
> > ----
> >  PVE/Network/SDN/Vnets.pm   | 16 ++++-----
> >  2 files changed, 49 insertions(+), 37 deletions(-)
> > 
> 
> looks OK, I wonder if we'd be more future proof if we went for adding
> a %param hash
> (or as reference with $param) instead, with the skip dns options as
> property?
> 
> Not to sure how much change potential there's here.

Ok no problem, I'll look for this.
(I'm currently reworking lxc ipam too, based on my last work on qemu-
server)

> 
> btw., did you checked out newer ifupdown2 already? I saw that
> upstream added a changelog
> entry already, but not yet tagged as release.
> 
I'm currently testing it. (I had asked to julien to push theses last
patches 2 week ago to have them before proxmox7 release, but it was a
bit late ^_^)
https://github.com/CumulusNetworks/ifupdown2/issues/211
I known they are a dhcp fix, needed by a user on the forum
https://github.com/CumulusNetworks/ifupdown2/commit/1eacb76b3ab634838559d3a2b5a4e39b98b21d10


I'll try to finish my tests the week. (I'm going to holiday next week
for 3 weeks)