[pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Jul 13 06:41:42 CEST 2021
On 12.07.21 00:48, Alexandre Derumier wrote:
> allow to register ip to ipam without dns registration.
> can be used for temp/pending ip for example
>
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
> PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++----------------
> PVE/Network/SDN/Vnets.pm | 16 ++++-----
> 2 files changed, 49 insertions(+), 37 deletions(-)
>
looks OK, I wonder if we'd be more future proof if we went for adding a %param hash
(or as reference with $param) instead, with the skip dns options as property?
Not to sure how much change potential there's here.
btw., did you checked out newer ifupdown2 already? I saw that upstream added a changelog
entry already, but not yet tagged as release.
More information about the pve-devel
mailing list