[pve-devel] applied: Re: [PATCH novnc] add patches to workaround fullscreen issue in android app

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Dec 21 11:41:18 CET 2021


On 20/12/2021 12:33, Dominik Csapak wrote:
> patch 15 hides the fullscreen button,
> patch 16 make the error message dismissable
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  ...-button-on-isFullscreen-get-variable.patch | 39 +++++++++++++++
>  debian/patches/0017-make-error-hideable.patch | 47 +++++++++++++++++++
>  debian/patches/series                         |  2 +
>  3 files changed, 88 insertions(+)
>  create mode 100644 debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
>  create mode 100644 debian/patches/0017-make-error-hideable.patch
> 
>

now with the 1.3 rebase done first  this applied cleanly, thanks!
FYI: I adapted the commit message so that the patch references are correct there.

IMO the "make error dismissable" should be upstreamed in some form, not sure if
clicking on it is the best general solution, as that can make copying an error
text hard, but either a X (text-)button or the like would surely be great for
them too.




More information about the pve-devel mailing list