[pve-devel] [PATCH flutter_frontend 2/2] remove unused drawables for android splash screen

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 20 20:25:19 CET 2021


On 20/12/2021 16:38, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
>  .../src/main/res/drawable/launch_background.xml |  11 -----------
>  .../drawable/proxmox_logo_white_orange_250.png  | Bin 10537 -> 0 bytes
>  .../drawable/proxmox_logo_white_orange_800.png  | Bin 17037 -> 0 bytes
>  3 files changed, 11 deletions(-)
>  delete mode 100644 android/app/src/main/res/drawable/launch_background.xml

above is avoided by just keeping the there in the first place

>  delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_250.png
>  delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_800.png
> 

and deleting those isn't really a benefit, git will still track it as part
of the repos history, so we'd not really safe space there and if one requires
those in the future again there's a chance that they overlook that there's one
already hidden in the git history and readds it, actually increasing space
usage, so as long as they do not actually hurt us lets just keep them..





More information about the pve-devel mailing list