[pve-devel] applied: [PATCH v2 widget-toolkit] improve error handling when adding webauthn entries

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Dec 2 19:19:44 CET 2021


On 30.11.21 11:04, Wolfgang Bumiller wrote:
> There are cases where we directly throw a string error
> (particularly, when navigator.credentials.create() fails,
> for example when trying to register the same WA device to
> the same user twice), which would end up with the WA window
> simply not closing before.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> ---
> changes to v1:
>   * move console.error() call up
>   * check for type `object` explicitly
>   * use `?.` operator to get the message
> 
>  src/window/AddWebauthn.js | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list