[pve-devel] [PATCH v4 storage 1/4] status: move unlink from http-server to enpoint

Lorenz Stechauner l.stechauner at proxmox.com
Tue Aug 31 12:16:29 CEST 2021


this is the first step in which not the http server removes the
temporary file, but the worker itself.

Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
---
 PVE/API2/Storage/Status.pm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index b838461..cc8ed5a 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Status.pm
@@ -486,6 +486,12 @@ __PACKAGE__->register_method ({
 	    print "command: " . join(' ', @$cmd) . "\n";
 
 	    eval { run_command($cmd, errmsg => 'import failed'); };
+
+	    # unlinks only the temporary file from the http server
+	    unlink $tmpfilename;
+	    warn "unable to clean up temporary file '$tmpfilename' - $!\n"
+		if $! && $! != ENOENT;
+
 	    if (my $err = $@) {
 		eval { $err_cleanup->() };
 		warn "$@" if $@;
-- 
2.30.2






More information about the pve-devel mailing list