[pve-devel] [PATCH RFC manager] ui: ceph install wizard: fix config exists note position

Aaron Lauterer a.lauterer at proxmox.com
Tue Aug 10 15:27:26 CEST 2021


During the Ceph installation, in the configuration step, a note is shown
if there already is a Ceph configuration present. This notification
should be in the center of the wizard but is currently barely visible.

ExtJS is having trouble calculating the position and the result is that
the note is placed almost out of the visible area.

Setting a fixed height helps ExtJS calculate the vertical position.
Changing from the 'beforeshow' listener to the 'afterrender' one helps
for the horizontal position.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
This feels quite hacky, hence the RFC so we can discuss a better
approach that I am not aware of yet.

 www/manager6/ceph/CephInstallWizard.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
index fc99029e..59458b0d 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++ b/www/manager6/ceph/CephInstallWizard.js
@@ -337,6 +337,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
 	    xtype: 'inputpanel',
 	    title: gettext('Configuration'),
 	    onlineHelp: 'chapter_pveceph',
+	    height: 300,
 	    cbind: {
 		nodename: '{nodename}',
 	    },
@@ -350,7 +351,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
 		activate: function() {
 		    this.up('pveCephInstallWizard').down('#submit').setText(gettext('Next'));
 		},
-		beforeshow: function() {
+		afterrender: function() {
 		    if (this.up('pveCephInstallWizard').getViewModel().get('configuration')) {
 			this.mask("Configuration already initialized", ['pve-static-mask']);
 		    } else {
-- 
2.30.2





More information about the pve-devel mailing list