[pve-devel] [RFC common 1/1] REST environment: add static log_warn function

Fabian Ebner f.ebner at proxmox.com
Fri Aug 6 14:57:11 CEST 2021


which can be called even when the environment is not initialized.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 src/PVE/RESTEnvironment.pm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index 189a6cd..4278966 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -712,14 +712,20 @@ sub fork_worker {
     return wantarray ? ($upid, $res) : $upid;
 }
 
-sub warn {
-    my ($self, $message) = @_;
+sub log_warn {
+    my ($message) = @_;
 
     chomp($message);
 
     print STDERR "WARN: $message\n";
 
-    $self->{warning_count}++;
+    $rest_env->{warning_count}++ if $rest_env;
+}
+
+sub warn {
+    my ($self, $message) = @_;
+
+    log_warn($message);
 }
 
 # Abstract function
-- 
2.30.2






More information about the pve-devel mailing list