[pve-devel] applied: [PATCH manager] ui: qemu/Config: disable xtermjs and spice until status is loaded

[Dominik Csapak]

On 4/20/21 18:20, Thomas Lamprecht wrote:
> On 20.04.21 16:35, Dominik Csapak wrote:
>> We enable/disable spice/xtermjs for the console button in the 'load'
>> callback of the statusstore, depending on the vms capabilities,
>> but until the first load there, the only safe option is novnc.
>>
>> So we have to disable xtermjs and spice on start, else a click on
>> the button might open a window that cannot connect to the vm.
>>
>> a forum user probably triggered this:
>> https://forum.proxmox.com/threads/unable-to-find-serial-interface-console-problem.87705
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   www/manager6/qemu/Config.js | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
>> index 10bf10a4..b5f8cc9c 100644
>> --- a/www/manager6/qemu/Config.js
>> +++ b/www/manager6/qemu/Config.js
>> @@ -199,6 +199,8 @@ Ext.define('PVE.qemu.Config', {
>>   	    disabled: !caps.vms['VM.Console'],
>>   	    hidden: template,
>>   	    consoleType: 'kvm',
>> +	    enableSpice: false,
>> +	    enableXtermjs: false,
>>   	    consoleName: vm.name,
>>   	    nodename: nodename,
>>   	    vmid: vmid,
>>
> 
> adding a comment could be nice to avoid people thinking to "clean this up" in the future.

yes, i'll add a comment

> 
> Anyway, applied. Related in the widest sense:
> 
> I have an issue with the default opened console viewer, a VM always opens the xtermjs
> one when IMO the spice viewer or noVNC one should be preferred.
> 
> Setup details
> 
> * windows VM
> ** display spice (qxl)
> ** serial port added
> * datacenter options for console viewer set to html5
> 

weird, works for me differently:

* datacenter html5
* vm with display spice + serial port
* opens novnc

i'll investigate