[pve-devel] applied-series: [PATCH manager 1/2] Fix #2053: OSD destroy only on specified node

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 20 18:10:22 CEST 2021


On 11.01.21 12:42, Dominic Jäger wrote:
> Allow destroying only OSDs that belong to the node that has been specified in
> the API path.
> 
> So if
>  - OSD 1 belongs to node A and
>  - OSD 2 belongs to node B
> then
>  - pvesh delete nodes/A/ceph/osd/1 is allowed but
>  - pvesh delete nodes/A/ceph/osd/2 is not
> 
> Destroying an OSD via GUI automatically inserts the correct node
> into the API path.
> 
> pveceph automatically insert the local node into the API call, too.
> Consequently, it can now only destroy local OSDs (fix #2053).
>  - pveceph osd destroy 1 is allowed on node A but
>  - pveceph osd destroy 2 is not
> 
> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> ---
>  PVE/API2/Ceph/OSD.pm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
>

applied, thanks!

I reworked the the filtering/parsing the $tree result a bit, maybe you can re-check
if all seem OK to you? The test are def. good and helped here - thanks for them!




More information about the pve-devel mailing list