[pve-devel] [PATCH v3 series 0/4] disk reassign: add new feature

[Aaron Lauterer]

This series implements a new feature which allows users to easily
reassign disks between VMs. Currently this is only possible with one of
the following manual steps:

* rename the disk image/file and do a `qm rescan`
* configure the disk manually and use the old image name, having an
    image for VM A assigned to VM B

The latter can cause unexpected behavior because PVE expects that the
VMID in a disk name always corresponds to the VM it is assigned to. Thus
when a disk, original from VM A was manually configured as disk for VM B
it happens that, when deleting VM A, the disk in question will be
deleted as well because it still had the VMID of VM A in it's name.

To issue a reassign from the CLI run:

qm reassign_disk <source VMID> <target VMID> <drive key>

where <drive key> is the config key of the disk, e.g. ide0, scsi1 and so
on.

The following storage types are implemented at the moment:
* dir based ones
    * directory
    * NFS
    * CIFS
    * gluster
* ZFS
* (thin) LVM
* Ceph RBD

v2 -> v3:
* change locking approach
* add more checks
* add intermedia storage plugin for directory based plugins
* use feature flags
* split up the reassign method to have a dedicated method for the
    renaming itself
* handle linked clones
* clean up if disk used to be replicated

I hope I didn't forget anything major.

v1 -> v2:
print info about the new disk volid and key at the end of the job so it
shows up in the CLI output and task log

Changes from RFC -> V1:
* support to reassign unused disks
* digest for target vm config
* reorder the checks a bit
* adding another one to check if the given key for the disk even exists
  in the config.


qemu-server: Aaron Lauterer (2):
  disk reassign: add API endpoint
  cli: disk reassign: add reassign_disk to qm command

 PVE/API2/Qemu.pm        | 156 ++++++++++++++++++++++++++++++++++++++++
 PVE/CLI/qm.pm           |   2 +
 PVE/QemuServer/Drive.pm |   4 ++
 3 files changed, 162 insertions(+)


storage: Aaron Lauterer (1):
  add disk reassign feature

 PVE/Storage.pm                 | 10 ++++++
 PVE/Storage/BaseDirPlugin.pm   | 61 ++++++++++++++++++++++++++++++++++
 PVE/Storage/CIFSPlugin.pm      |  2 +-
 PVE/Storage/DirPlugin.pm       |  2 +-
 PVE/Storage/GlusterfsPlugin.pm |  2 +-
 PVE/Storage/LVMPlugin.pm       | 24 +++++++++++++
 PVE/Storage/LvmThinPlugin.pm   |  1 +
 PVE/Storage/Makefile           |  1 +
 PVE/Storage/NFSPlugin.pm       |  2 +-
 PVE/Storage/Plugin.pm          | 22 ++++++------
 PVE/Storage/RBDPlugin.pm       | 31 +++++++++++++++++
 PVE/Storage/ZFSPoolPlugin.pm   | 28 ++++++++++++++++
 12 files changed, 172 insertions(+), 14 deletions(-)
 create mode 100644 PVE/Storage/BaseDirPlugin.pm


widget-toolkit: Aaron Lauterer (1):
  utils: task_desc_table: add qmreassign

 src/Utils.js | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1