[pve-devel] applied: Re: [PATCH widget-toolkit] return cookie again in authOK

Thomas Lamprecht t.lamprecht at proxmox.com
Mon May 25 13:54:12 CEST 2020


On 5/25/20 1:46 PM, Dominik Csapak wrote:
> the calling code did require that authOK returns the cookie if
> there is a valid one
> 
> make it now very explicit that the cookie gets returned instead
> of using implicit short-circuit behaviour
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  Utils.js | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
>

applied, thanks! Shortly thought about complaining regarding returning two different
falsy values, undefined on Proxmox.LoggedOut, false on that cookie/tfa check but it
was the behavior before, so OK I guess ^^




More information about the pve-devel mailing list