[pve-devel] applied-series: Re: [PATCH V2 pve-network 0/6] always use a vnet bridge model

[Alexandre DERUMIER]

>>pplied series, thanks! There could be probably some improved error checking/warnings,
>>e.g., if a QinQ bridge exists, ideally with a "Info" column in the general SDN status
>>panel where such erros are then also visible (as it's checked on apply).

yes, I need to improve that.
I'll look at this next week.


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Mardi 19 Mai 2020 21:45:15
Objet: applied-series: Re: [pve-devel] [PATCH V2 pve-network 0/6] always use a vnet bridge model

On 5/19/20 6:37 PM, Alexandre Derumier wrote: 
> Hi, 
> 
> this is a rework of vlan && qinq plugin to always use a vnet=20 
> bridge for all plugin. 
> 
> Avoid to tag vmport directly on vlan-aware bridge or ovs. 
> Instead, plug the vm interface on a vnet bridge, and plug the 
> vnet bridge on the ovs|bridge-vlan-aware|... and do the tag here. 
> 
> This will help a lot of handling tag modification on a vnet, as we=20 
> don't defined tap|veth in /etc/network/interfaces, 
> and make same vnet model for each plugins. 
> 
> Qinq plugin was buggy, I have fixed it and added support for 
> ovs+classic linux bridge. 
> I have also added vlan-protocol option back, to handle=20 
> both 802.1ad && 802.1q service vlan. 
> 
> I'll update documentation && gui tomorrow 
> 
> 
> Changelog v2: 
> 
> - keep interfaces sort 
> - fix the vnet name character to 8 
> 
> Alexandre Derumier (6): 
> restrict zone name to 8 characters 
> retrict vnet name to 8 characters 
> vlan: use new model 
> qinq: use new model + ovs/classic bridge support 
> evpn: prefix interfaces 
> vxlan: prefix interfaces 
> 
> PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- 
> PVE/Network/SDN/VnetPlugin.pm | 2 +- 
> PVE/Network/SDN/Zones/EvpnPlugin.pm | 24 ++-- 
> PVE/Network/SDN/Zones/Plugin.pm | 2 +- 
> PVE/Network/SDN/Zones/QinQPlugin.pm | 133 +++++++++++++++++----- 
> PVE/Network/SDN/Zones/VlanPlugin.pm | 90 ++++++++++----- 
> PVE/Network/SDN/Zones/VxlanPlugin.pm | 6 +- 
> 7 files changed, 183 insertions(+), 76 deletions(-) 
> 



applied series, thanks! There could be probably some improved error checking/warnings, 
e.g., if a QinQ bridge exists, ideally with a "Info" column in the general SDN status 
panel where such erros are then also visible (as it's checked on apply).