[pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

[Alexandre DERUMIER]

I have retest all plugins with last code,
I don't have this problem anymore, 

I think I have some bad config during my rework and ifupdown2 couldn't handle it correclty.

I'll remove this patch.


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mardi 19 Mai 2020 17:50:30
Objet: Re: [pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

>>makes no sense, this is a hash and perl actively re-orders the return 
>>set of keys pseudo-randomly .. 
>> 
>>If order is really required use an array. 

Damn, you are right. 

I think I'm going to make some ordering by kind of interfaces, like for /etc/network/interfaces 

----- Mail original ----- 
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com> 
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com> 
Envoyé: Mardi 19 Mai 2020 16:43:20 
Objet: Re: [pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn 

On 5/19/20 3:48 PM, Alexandre Derumier wrote: 
> Sometime, ifupdown2 can't handle depend correctly, and interface order is used 
> 

makes no sense, this is a hash and perl actively re-orders the return 
set of keys pseudo-randomly .. 

If order is really required use an array. 

> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> PVE/Network/SDN/Zones.pm | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm 
> index 436b103..435e40b 100644 
> --- a/PVE/Network/SDN/Zones.pm 
> +++ b/PVE/Network/SDN/Zones.pm 
> @@ -113,7 +113,7 @@ sub generate_etc_network_config { 
> } 
> 
> my $raw_network_config = "\#version:$version\n"; 
> - foreach my $iface (sort keys %$config) { 
> + foreach my $iface (keys %$config) { 
> $raw_network_config .= "\n"; 
> $raw_network_config .= "auto $iface\n"; 
> $raw_network_config .= "iface $iface\n"; 
> 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel