[pve-devel] [PATCH storage 5/6] archive info: include archive name in error message

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 15 19:23:43 CEST 2020


so that we have some context if users report issues with it..

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 PVE/Storage.pm            | 2 +-
 test/archive_info_test.pm | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index b01211d..df8d6fe 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -1402,7 +1402,7 @@ sub archive_info {
 	    $info->{type} = $1;
 	}
     } else {
-	die "ERROR: couldn't determine format and compression type\n";
+	die "ERROR: couldn't determine archive info from '$archive'\n";
     }
 
     return $info;
diff --git a/test/archive_info_test.pm b/test/archive_info_test.pm
index c0343af..dd4a635 100644
--- a/test/archive_info_test.pm
+++ b/test/archive_info_test.pm
@@ -100,10 +100,11 @@ my $non_bkp_suffix = {
 for my $virt (sort keys %$non_bkp_suffix) {
     my $suffix = $non_bkp_suffix->{$virt};
     for my $s (@$suffix) {
+	my $archive = "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$s";
 	push @$tests, {
 	    description => "Failed match: Backup archive, $virt, $s",
-	    archive     => "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$s",
-	    expected    => "ERROR: couldn't determine format and compression type\n",
+	    archive     => $archive,
+	    expected    => "ERROR: couldn't determine archive info from '$archive'\n",
 	};
     }
 }
-- 
2.20.1





More information about the pve-devel mailing list