[pve-devel] [PATCH storage 2/6] tests: archive info: code cleanup

[Thomas Lamprecht]

We could also do a hash array slice, like:
> my ($archive, $expected, $description) = $tt->@{'archive', 'expected', 'description'};

But as none are optional lets just access values directly..

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 test/archive_info_test.pm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/test/archive_info_test.pm b/test/archive_info_test.pm
index 7db02d1..60d606e 100644
--- a/test/archive_info_test.pm
+++ b/test/archive_info_test.pm
@@ -119,16 +119,12 @@ foreach my $virt (keys %$non_bkp_suffix) {
 
 plan tests => scalar @$tests;
 
-# run through tests array
-foreach my $tt (@$tests) {
-    my $description = $tt->{description};
-    my $archive = $tt->{archive};
-    my $expected = $tt->{expected};
-    my $got;
-    eval { $got = PVE::Storage::archive_info($archive) };
+for my $tt (@$tests) {
+
+    my $got = eval { PVE::Storage::archive_info($tt->{archive}) };
     $got = $@ if $@;
 
-    is_deeply($got, $expected, $description) || diag(explain($got));
+    is_deeply($got, $tt->{expected}, $tt->{description}) || diag(explain($got));
 }
 
 done_testing();
-- 
2.20.1