[pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

[Thomas Lamprecht]

On 5/7/20 10:27 AM, Dominik Csapak wrote:
> so that they are get automatically reloaded with the default interval (3seconds)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> this patch needs the widget-toolkit patches applied
> we can of course leave those out, and to it manually in initComponent,
> but this is a pattern we often use and maybe we can remove more manually
> crated rstore/diffstore combos in other places

hmm, I now get a short glitch off "No accounts configured" shown when adding
a second or removing a second account.

Semi-related, if an account with "default" already exists it would be great
if the emptyText gets dropped and the field gets required, as a second account
with "default" cannot be added anyway, but rather minor nit..

> 
>  www/manager6/dc/ACMEClusterView.js | 24 +++++++++++++++++++-----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/www/manager6/dc/ACMEClusterView.js b/www/manager6/dc/ACMEClusterView.js
> index 228d1cf9..00db8e9f 100644
> --- a/www/manager6/dc/ACMEClusterView.js
> +++ b/www/manager6/dc/ACMEClusterView.js
> @@ -90,8 +90,15 @@ Ext.define('PVE.dc.ACMEAccountView', {
>      },
>  
>      store: {
> -	model: 'pve-acme-accounts',
> -	autoLoad: true,
> +	type: 'diff',
> +	autoDestroy: true,
> +	autoDestroyRstore: true,
> +	rstore: {
> +	    type: 'update',
> +	    storeid: 'pve-acme-accounts',
> +	    model: 'pve-acme-accounts',
> +	    autoStart: true,
> +	},
>  	sorters: 'name',
>      },
>  });
> @@ -179,9 +186,16 @@ Ext.define('PVE.dc.ACMEPluginView', {
>      },
>  
>      store: {
> -	model: 'pve-acme-plugins',
> -	autoLoad: true,
> -	filters: item => !!item.data.api,
> +	type: 'diff',
> +	autoDestroy: true,
> +	autoDestroyRstore: true,
> +	rstore: {
> +	    type: 'update',
> +	    storeid: 'pve-acme-plugins',
> +	    model: 'pve-acme-plugins',
> +	    autoStart: true,
> +	    filters: item => !!item.data.api,
> +	},
>  	sorters: 'plugin',
>      },
>  });
>