[pve-devel] applied: [PATCH v2 qemu-server 2/6] api: allow listing custom and default CPU models
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed May 6 17:25:55 CEST 2020
On 5/6/20 5:20 PM, Stefan Reiter wrote:
> On 5/6/20 4:52 PM, Thomas Lamprecht wrote:
>> On 5/4/20 12:58 PM, Stefan Reiter wrote:
>>> More API calls will follow for this path, for now add the 'index' call to
>>> list all custom and default CPU models.
>>>
>>> Any user can list the default CPU models, as these are public anyway, but
>>> custom models are restricted to users with Sys.Audit on /nodes.
>>>
>>> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
>>> ---
>>> PVE/API2/Qemu/CPU.pm | 61 +++++++++++++++++++++++++++++++++++++
>>> PVE/API2/Qemu/Makefile | 2 +-
>>> PVE/QemuServer/CPUConfig.pm | 30 ++++++++++++++++++
>>> 3 files changed, 92 insertions(+), 1 deletion(-)
>>> create mode 100644 PVE/API2/Qemu/CPU.pm
>>>
>>
>> applied, thanks!
>>
>> Albeit API call shouldn't say that it's return values are links to API sub
>> directory/paths if they ain't..
>>
>
> Ah sorry, I removed this locally but must've forgotten to check it in.
>
> It's probably best to remove this entirely for now, it's not just wrong now but also wrong wrt. my upcoming changes... (I put the individual queries under .../cpu/model/<name> , so I could also have .../cpu/supported-flags etc. without mixing dynamic and static paths)
send a patch for whatever, and reply to series not which are, or will be
soon, outdated - thanks!
More information about the pve-devel
mailing list