[pve-devel] [PATCH guest-common 1/2] Avoid duplication by using lock_config_mode

[Fabian Ebner]

On 5/4/20 6:02 PM, Thomas Lamprecht wrote:
> On 4/23/20 1:51 PM, Fabian Ebner wrote:
>> No functional change is intended.
>>
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>   PVE/AbstractConfig.pm | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
>> index beb10c7..f1b395c 100644
>> --- a/PVE/AbstractConfig.pm
>> +++ b/PVE/AbstractConfig.pm
>> @@ -259,13 +259,7 @@ sub load_current_config {
>>   sub lock_config_full {
>>       my ($class, $vmid, $timeout, $code, @param) = @_;
>>   
>> -    my $filename = $class->config_file_lock($vmid);
>> -
>> -    my $res = lock_file($filename, $timeout, $code, @param);
>> -
>> -    die $@ if $@;
>> -
>> -    return $res;
>> +    return $class->lock_config_mode($vmid, $timeout, 0, $code, @param);
>>   }
>>   
>>   sub create_and_lock_config {
>>
> 
> so I lost a bit track on the remaining patches from both of you. There seem
> some nits/unrelated hunks which got commented (e.g., patch guest-common 1/3).
> I'd appreciated if one of you could pick this up and send a nice v2 with
> those addressed and R-b tags where applicable.
> 

Ok, I'll send out a v2