[pve-devel] applied: [PATCH v2 common] print_text_table: handle undefined values in comparision

Thomas Lamprecht t.lamprecht at proxmox.com
Mon May 4 18:21:43 CEST 2020


On 4/28/20 12:00 PM, Oğuz Bektaş wrote:
>> Fabian Ebner <f.ebner at proxmox.com> hat am 28. April 2020 10:18 geschrieben:
>>
>>  
>> by introducing a safe_compare helper. Fixes warnings, e.g.
>> pvesh get /nodes/<NODE>/network
>> would print "use of uninitialized"-warnings if there are inactive
>> network interfaces, because for those, 'active' is undef.
>>
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>
>> Changes from v1:
>>     * don't change sort_key depending on data
>>     * instead handle undefined values directly
>>       in comparision
>>
>>  src/PVE/CLIFormatter.pm | 11 +++++++----
>>  src/PVE/Tools.pm        |  9 +++++++++
>>  2 files changed, 16 insertions(+), 4 deletions(-)
>>
>
> Tested-by: Oguz Bektas <o.bektas at proxmox.com>

 
with that: applied, thanks!





More information about the pve-devel mailing list