[pve-devel] [PATCH common] inotify: fix compatibillity with address + netmask separate passed

[Alexandre DERUMIER]

I try to look for the problem with network list api called by networkselector widget

I'm not sure if the "address" return from api should be fixed in api, or in Inotify read interface ? 
(because I think fixing it in read_interface, will rewrite it without cidr in write_interface ?)



Also, for multiple ips, networkselector will need to be fixed too to handle multiple ips


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Jeudi 12 Mars 2020 17:46:47
Objet: Re: [pve-devel] [PATCH common] inotify: fix compatibillity with address + netmask separate passed

On 3/12/20 5:34 PM, Alexandre DERUMIER wrote: 
> Sorry about this :/ 
> 
> I had tested it only with the multiple cidr patch, 
> and I think I had fixed this at the api side 
> https://www.mail-archive.com/pve-devel@pve.proxmox.com/msg38283.html 
> 
> + } elsif ($param->{address} && $param->{netmask}) { 
> + $param->{address} = ["$param->{address}/$param->{netmask}"]; 
> } 

yeah, I saw this now - but as we have the other compat code also in pve-common, 
and I like it more if it's a central place - to avoid that every caller would need 
to adapt and handle compatibility, so I added this in INotify from pve-common. 

I mean, actually I should've seen this connection on review, but I only checked 
read side. So nothing to excuse for :) 

FYI: The multiple cidr patch (api and common) would need to be rebased.