[pve-devel] [PATCH common] inotify: fix compatibillity with address + netmask separate passed

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Mar 12 17:46:47 CET 2020


On 3/12/20 5:34 PM, Alexandre DERUMIER wrote:
> Sorry about this :/
> 
> I had tested it only with the multiple cidr patch,
> and I think I had fixed this at the api side
> https://www.mail-archive.com/pve-devel@pve.proxmox.com/msg38283.html
> 
> +    } elsif ($param->{address} && $param->{netmask}) {
> +       $param->{address} = ["$param->{address}/$param->{netmask}"];
>      }

yeah, I saw this now - but as we have the other compat code also in pve-common,
and I like it more if it's a central place - to avoid that every caller would need
to adapt and handle compatibility, so I added this in INotify from pve-common.

I mean, actually I should've seen this connection on review, but I only checked
read side. So nothing to excuse for :)

FYI: The multiple cidr patch (api and common) would need to be rebased.




More information about the pve-devel mailing list