[pve-devel] [PATCH v2 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

[Thomas Lamprecht]

On 3/5/20 10:51 AM, Dominik Csapak wrote:
>> +        # wipefs location:
>> +        #  - Debian  9: /sbin/wipefs
>> +        #  - Debian 10: /usr/sbin/wipefs
>> +        # The symlink from /sbin to /usr/sbin makes this work for fresh PVE
> 
> the comment is odd:

working with a mix of usr merged and unmerged systems makes one go odd ways ^^

> pve6 here:
> 
> # which wipefs
> /sbin/wipefs
> 
> # dpkg -S /sbin/wipefs
> util-linux
> 
> # dpkg -L util-linux
> /sbin/wipefs
> /usr/share/bash[...]
> /usr/share/man[...]

for the record: just use it without any path and be usr merge save. We have a lot of
precedents using run_command with the binary names only, relying on $PATH to be sane -
if that would become a problem in any way (when the system then probably isn't to
usable either) we would enforce the our-chosen-sane-PATH value in run_command as central
place anyway.