[pve-devel] [PATCH v2 guest-common] abstractconfig: add prototype for get_backup_volumes

[Aaron Lauterer]

On 2/27/20 11:01 AM, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> v1[0] -> v2:
> given the feedback from Fabian I
> * changed name of the method
> * added more details as to what implementations should return
> 
> [0] https://pve.proxmox.com/pipermail/pve-devel/2020-January/041267.html
> 
> 
>   PVE/AbstractConfig.pm | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
> index 782714f..aab84ff 100644
> --- a/PVE/AbstractConfig.pm
> +++ b/PVE/AbstractConfig.pm
> @@ -366,6 +366,24 @@ sub get_replicatable_volumes {
>       die "implement me - abstract method\n";
>   }
>   
> +# Returns whether the guests volumes are included in a vzdump job
> +# Return Format:
> +# referenced array with hashes as elements:
> +# [
> +#   {
> +#	key,	    key in the config, e.g. mp0, scsi0,...
> +#	included,   boolean
> +#	reason,	    string
> +#	volume,	    volid / mountpoint
That line slipped through here. It's not present in the actual code.

> +#	data	    volume object as returned from foreach_drive/foreach_mountpoint
> +#	},
> +# ]
> +sub get_backup_volumes {
> +    my ($class, $conf) = @_;
> +
> +    die "implement me - abstract method\n";
> +}
> +
>   # Internal snapshots
>   
>   # NOTE: Snapshot create/delete involves several non-atomic
>