[pve-devel] [PATCH-SERIES v3] Move drive-related code into its own module

Fabian Ebner f.ebner at proxmox.com
Mon Mar 2 11:33:41 CET 2020


Note this is the next version of the first part of the old series [0].

Changes from v2:
    * Move more subroutines and also 'unuseddesc'
    * Rename 'disksize' and 'print_drive_full'
    * Some new smaller fixes (patches #6 and #7) not directly related
      to moving (but touching the same code)

[0]: https://pve.proxmox.com/pipermail/pve-devel/2020-February/041910.html

Fabian Ebner (7):
  Replace drivename_hash with drivedesc_hash
  Use parse_drive for EFI disk
  Create Drive.pm and move drive-related code there
  Rename disksize to bootdisk_size and print_drive_full to
    print_drive_commandline_full
  Use MAX_UNUSED_DISKS from Drive.pm to avoid duplication
  Use correct description for unused drives
  Also update disk size if there was no old size

 PVE/API2/Qemu.pm        |  11 +-
 PVE/CLI/qm.pm           |   3 +-
 PVE/QemuConfig.pm       |   5 +-
 PVE/QemuMigrate.pm      |   3 +-
 PVE/QemuServer.pm       | 660 ++--------------------------------------
 PVE/QemuServer/Drive.pm | 647 +++++++++++++++++++++++++++++++++++++++
 PVE/QemuServer/Makefile |   1 +
 7 files changed, 678 insertions(+), 652 deletions(-)
 create mode 100644 PVE/QemuServer/Drive.pm

-- 
2.20.1





More information about the pve-devel mailing list