[pve-devel] [PATCH xtermjs v2 4/4] ui: prevent accidental closing of terminal window

Dominik Csapak d.csapak at proxmox.com
Tue Jul 14 13:51:06 CEST 2020


this prevents closing the window e.g. when pressing ctrl+w

most browsers have a function to block a website from doing that,
so users that do not want that, simply have to click that option

also, the message will (at least in chrome) not be displayed,
instead a fixed message will appear

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
new in v2, please interpret as RFC
 src/www/main.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/www/main.js b/src/www/main.js
index 55834eb..43fe656 100644
--- a/src/www/main.js
+++ b/src/www/main.js
@@ -143,7 +143,7 @@ function createTerminal() {
 	    socket.onopen = runTerminal;
 	    socket.onclose = tryReconnect;
 	    socket.onerror = tryReconnect;
-	    window.onbeforeunload = stopTerminal;
+	    window.onbeforeunload = windowUnload;
 	    updateState(states.connecting);
 	},
 	failure: function(msg) {
@@ -303,6 +303,17 @@ function clearEvents() {
     term.onData(() => {});
 }
 
+function windowUnload(e) {
+    let message = "Are you sure you want to leave this page?";
+
+    e = e || window.event;
+    if (e) {
+	e.returnValue = message;
+    }
+
+    return message;
+}
+
 function stopTerminal(event) {
     event = event || {};
     clearEvents();
-- 
2.20.1






More information about the pve-devel mailing list