[pve-devel] [RFC v2 0/3] nvme emulation

[Oguz Bektas]

hi,

the email i've sent to qemu-discuss list to ask about this issue while
reattaching a drive with the same id has gone unanswered...

how do we want to proceed with this feature?

maybe we can fix this issue or workaround it somehow?


On Mon, May 18, 2020 at 05:34:01PM +0200, Oguz Bektas wrote:
> add support for nvme emulation.
> 
> v1->v2:
> * implement thomas' suggestions from mailing list
> 
> 
> i'm sending this as RFC because of the following issue, maybe someone has a tip for me:
> 
> alpine linux vm, with 5 disks. nvme0-4 and sata0.
> hot-unplug nvme4. this works.
> re-hotplug nvme4 without rebooting will cause the following error:
> 
> ---
> TASK ERROR: 400 Parameter verification failed. 
> nvme4: hotplug problem - adding drive failed: Duplicate ID 'drive-nvme4' for drive
> ---
> 
> and drive cannot be hotplugged with the same name until reboot. changing the id from nvme4 to nvme5 will work however...
> 
> i'm not sure why this happens, something in qemu isn't being deleted after removing the device/drive, but `info qtree` and `info qom-tree` do
> not show nvme4 after being unplugged.
> 
> 
> 
> 
> 
> qemu-server:
> Oguz Bektas (2):
>   fix #2255: add support for nvme emulation
>   drive: use more compact for-loop expression for initializing drive
>     descriptions
> 
>  PVE/QemuServer.pm       | 23 ++++++++++++++++++++---
>  PVE/QemuServer/Drive.pm | 38 +++++++++++++++++++++++---------------
>  2 files changed, 43 insertions(+), 18 deletions(-)
> 
> pve-manager:
> Oguz Bektas (1):
>   gui: add nvme as a bus type for creating disks
> 
>  www/manager6/Utils.js                   | 3 ++-
>  www/manager6/form/BusTypeSelector.js    | 2 ++
>  www/manager6/form/ControllerSelector.js | 4 ++--
>  www/manager6/qemu/CloudInit.js          | 4 ++--
>  www/mobile/QemuSummary.js               | 2 +-
>  5 files changed, 9 insertions(+), 6 deletions(-)
> 
> 
> -- 
> 2.20.1
> 
>