[pve-devel] applied: [PATCH v3 cluster 1/4] corosync: add verify_conf

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jan 30 20:27:33 CET 2020


On 1/9/20 4:31 PM, Stefan Reiter wrote:
> It does some basic sanity checking, warns the user about encryption
> settings and unresolved hostnames, and finally makes sure that all nodes
> have the same links configured (as well as comparing the configured
> links to specified interfaces, if there are any).
> 
> A corosync.conf that has been created and modified strictly through our
> API should *always* be valid.
> 
> verify_conf is called in 'addnode', warnings and errors are returned via
> the API to be displayed in the task log of the node asking to join. If a
> verification error occurs, it is handled specially via a "raise" outside
> of any lock code that strips extra information from an Exception
> instance. This ensures that multi-line formatted errors can be returned.
> Warnings are always returned as array, to be printed on the caller.
> 
> Includes testing.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  data/PVE/API2/ClusterConfig.pm    |  40 ++++++++++-
>  data/PVE/Cluster/Setup.pm         |  23 +++++-
>  data/PVE/Corosync.pm              | 116 +++++++++++++++++++++++++++++-
>  data/test/corosync_parser_test.pl |  29 ++++++++
>  4 files changed, 205 insertions(+), 3 deletions(-)
> 


applied, thanks!




More information about the pve-devel mailing list