[pve-devel] applied: [PATCH qemu-server] hotplug_pending: make 'ssd' option non-hotpluggable

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jan 30 20:23:05 CET 2020


On 1/16/20 4:06 PM, Oguz Bektas wrote:
> from hotplug_pending we go into 'vmconfig_update_disk', where we check the
> hotpluggability of options.
> 
> add 'ssd' there as a non-hotpluggable option (since we'd have to unplug/plug to
> change the drive type)
> 
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  PVE/QemuServer.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index c2547d6..1d01a68 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5252,7 +5252,8 @@ sub vmconfig_update_disk {
>  		    if (&$safe_string_ne($drive->{discard}, $old_drive->{discard}) ||
>  			&$safe_string_ne($drive->{iothread}, $old_drive->{iothread}) ||
>  			&$safe_string_ne($drive->{queues}, $old_drive->{queues}) ||
> -			&$safe_string_ne($drive->{cache}, $old_drive->{cache})) {
> +			&$safe_string_ne($drive->{cache}, $old_drive->{cache}) ||
> +			&$safe_string_ne($drive->{ssd}, $old_drive->{ssd})) {
>  			die "skip\n";
>  		    }
>  
> 

applied, thanks!



More information about the pve-devel mailing list