[pve-devel] applied-series: [PATCH pve-common 0/2] Inotify: improve vlan parser

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Jan 25 16:05:23 CET 2020


On 1/25/20 10:27 AM, Alexandre Derumier wrote:
> Improve parsing and creation of vlans interface.
> 3 kind of naming is possible:
> 
> ifupdown1/2:
> 
> - iface interface.\d+
> 
> - iface vlan\d+
>      vlan-raw-interface <interface>
> 
> ifupdown2 only:
> 
> - iface randomname
>     vlan-raw-interface <interface>
>     vlan-id \d+
> 
> 
> #pvesh create /nodes/<node>/network --iface eno1.200 --type vlan
> #pvesh create /nodes/<node>/network --iface vlan200 --type vlan --vlan-raw-device eno1
> #pvesh create /nodes/<node>/network --iface randomname --type vlan --vlan-raw-device eno1 --vlan-id 200

Applied series, thanks! Do we win something else besides "just" the flexibility and
being able to parse all possibilities?

The lather is OK and nice, but I'd not allow to set to many different styles
through Web interface if there's no other benefit - makes things more confusing
for inexperienced users..

> 
> Alexandre Derumier (2):
>   INotify: improve vlan interface parsing
>   tests: unknown interfaces order: rename vlan interfaces to unknown
> 
>  src/PVE/INotify.pm                            | 38 ++++++++++++++++---
>  .../etc_network_interfaces/t.unknown_order.pl | 26 ++++++-------
>  2 files changed, 43 insertions(+), 21 deletions(-)
> 




More information about the pve-devel mailing list