[pve-devel] applied: [PATCH qemu-server 2/2] Use 'volname' instead of 'volid' for 'qemu_img_format'

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jan 21 07:49:47 CET 2020


On 1/20/20 2:00 PM, Fabian Ebner wrote:
> As 'qemu_img_format' just matches a regex, this doesn't make much of
> a difference, but AFAICT all other calls of 'qemu_img_format' use 'volname'.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 59335c5..bcdadca 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5387,7 +5387,7 @@ sub vm_start {
>  		    $format = (grep {$fileFormat eq $_} @{$validFormats}) ? $fileFormat : $defFormat;
>  		} else {
>  		    my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
> -		    $format = qemu_img_format($scfg, $volid);
> +		    $format = qemu_img_format($scfg, $volname);
>  		}
>  
>  		my $newvolid = PVE::Storage::vdisk_alloc($storecfg, $storeid, $vmid, $format, undef, ($drive->{size}/1024));
> 

applied, thanks!



More information about the pve-devel mailing list