[pve-devel] applied: [PATCH v2 access-control 05/23] rpcenv: drop unused roles()

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jan 14 12:27:45 CET 2020


On 11/21/19 3:43 PM, Fabian Grünbichler wrote:
> it was useful for test-cases to verify the behaviour when pools where
> introduced, but it is not used anywhere else in the code base and those
> tests can also just check on permission-level.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     alternatively, we can give this the same semantics w.r.t. tokens as
>     PVE::AccessControl::roles, but with pool roles mixed in via
>     $compile_acl_path->()
> 
>  PVE/AccessControl.pm  |  2 +-
>  PVE/RPCEnvironment.pm | 23 ------------------
>  test/perm-test5.pl    |  2 +-
>  test/perm-test6.pl    | 54 +++++++++++++++++++++++++++++++------------
>  test/perm-test7.pl    | 24 +++++++++++++++++--
>  5 files changed, 63 insertions(+), 42 deletions(-)
> 

applied, thanks!





More information about the pve-devel mailing list