[pve-devel] applied: [PATCH qemu-server] Remove unused 'sharedvm' variable

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jan 9 17:44:49 CET 2020


On 1/9/20 10:23 AM, Fabian Ebner wrote:
> AFAICT this one hasn't been in use since commit
> '4530494bf9f3d45c4a405c53ef3688e641f6bd8e'
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuMigrate.pm | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index 0353458..49848e8 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -282,8 +282,6 @@ sub sync_disks {
>  	my $other_errors = [];
>  	my $abort = 0;
>  
> -	my $sharedvm = 1;
> -
>  	my $log_error = sub {
>  	    my ($msg, $volid) = @_;
>  
> @@ -310,7 +308,6 @@ sub sync_disks {
>  
>  	    # check if storage is available on target node
>  	    PVE::Storage::storage_check_node($self->{storecfg}, $targetsid, $self->{node});
> -	    $sharedvm = 0; # there is a non-shared disk
>  
>  	    PVE::Storage::foreach_volid($dl, sub {
>  		my ($volid, $sid, $volname) = @_;
> @@ -352,8 +349,6 @@ sub sync_disks {
>  
>  	    return if $scfg->{shared};
>  
> -	    $sharedvm = 0;
> -
>  	    $local_volumes->{$volid}->{ref} = $attr->{referenced_in_config} ? 'config' : 'snapshot';
>  
>  	    if ($attr->{cdrom}) {
> 

applied, thanks!




More information about the pve-devel mailing list