[pve-devel] [PATCH V2 ifupdown2 2/3] add debian/rules

[Alexandre DERUMIER]

>>Hmm, not here, diff between the two says there's no differences, also checking
>>out the file shows that the ifupdown2 2.0.1-1 tag has this commented out:

oh, sorry. maybe I was drunk ^_^.


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "Alexandre Derumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 9 Janvier 2020 14:10:29
Objet: Re: [pve-devel] [PATCH V2 ifupdown2 2/3] add debian/rules

On 1/9/20 2:05 PM, Alexandre DERUMIER wrote: 
>>> this is the exact same one as ifupdown2 ships in it's debian/ folder, so as we 
>>> just sync our debian folder into their (i.e., no full overwrite) we could omit this. 
>>> Or do I miss something? 
> 
> I have commented 
> 
> #export DH_VERBOSE=1 
> 
> I don't know why, but when it's enabled, the patches series don't seem to be applied when dpkg-buildpackage is running 
> (don't have found any infos about this) 

Hmm, not here, diff between the two says there's no differences, also checking 
out the file shows that the ifupdown2 2.0.1-1 tag has this commented out: 

$ git checkout 2.0.1-1 
HEAD is now at e65fae4 debian: changelog: new 2.0.1-1 entry 
$ head debian/rules 
#!/usr/bin/make -f 

#export DH_VERBOSE=1 
export PYBUILD_NAME=ifupdown2 
export PYBUILD_INSTALL_ARGS=--install-lib=/usr/share/ --install-scripts=/usr/share/ 

%: 
dh $@ --with python2 --with systemd --buildsystem=pybuild 

override_dh_installman: 

As this builds here I'll just omit the 2/3 patch :) 

> 
> ----- Mail original ----- 
> De: "Thomas Lamprecht" <t.lamprecht at proxmox.com> 
> À: "pve-devel" <pve-devel at pve.proxmox.com>, "Alexandre Derumier" <aderumier at odiso.com> 
> Envoyé: Jeudi 9 Janvier 2020 13:09:30 
> Objet: Re: [pve-devel] [PATCH V2 ifupdown2 2/3] add debian/rules 
> 
> On 1/9/20 12:23 PM, Alexandre Derumier wrote: 
>> comment export DH_VERBOSE=1 to have patches applied 
>> 
>> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
>> --- 
>> debian/rules | 27 +++++++++++++++++++++++++++ 
>> 1 file changed, 27 insertions(+) 
>> create mode 100755 debian/rules 
>> 
>> diff --git a/debian/rules b/debian/rules 
>> new file mode 100755 
>> index 0000000..6274b3a 
>> --- /dev/null 
>> +++ b/debian/rules 
>> @@ -0,0 +1,27 @@ 
>> +#!/usr/bin/make -f 
>> + 
>> +#export DH_VERBOSE=1 
>> +export PYBUILD_NAME=ifupdown2 
>> +export PYBUILD_INSTALL_ARGS=--install-lib=/usr/share/ --install-scripts=/usr/share/ 
>> + 
>> +%: 
>> + dh $@ --with python2 --with systemd --buildsystem=pybuild 
>> + 
>> +override_dh_installman: 
>> + ./ifupdown2/man/genmanpages.sh ./ifupdown2/man ./man 
>> + dh_installman 
>> + 
>> +override_dh_install: 
>> + dh_install 
>> + mkdir -p debian/ifupdown2/lib/systemd/system/ 
>> + install --mode=644 debian/ifup at .service debian/ifupdown2/lib/systemd/system/ 
>> + 
>> + 
>> +override_dh_systemd_start: 
>> + dh_systemd_start --name=networking --no-start 
>> + 
>> +override_dh_systemd_enable: 
>> + dh_systemd_enable --name=networking 
>> + 
>> +override_dh_compress: 
>> + dh_compress -X.py 
>> 
> 
> this is the exact same one as ifupdown2 ships in it's debian/ folder, so as we 
> just sync our debian folder into their (i.e., no full overwrite) we could omit this. 
> Or do I miss something? 
> 
>