[pve-devel] [PATCH proxmox-widget-toolkit 0/2] local network config improvements

[Dominik Csapak]

On 1/9/20 5:57 AM, Alexandre DERUMIER wrote:
>>> looks mostly ok, (i'll write an extra mail with comments for 2/2)
>>> but if you add this, you also have to add the api functions for
>>> pmg[0] otherwise the next widget-toolkit update adds those fields
>>>>> that do not work there
>>>
>>> i guess that it would suffice (for now) to simply make
>>> the same changes from pve-managers Network.pm in pmg-api
>>>
>>> (longterm we should really refactor that...)
> 
> sorry, I have forget about pmg. (I never has used it).

no problem, but we have to be careful about that.
we should probably mention somewhere in the
dev-docs or in widget-toolkit that if they are
modified, both pve and pmg have to be looked at

> 
> I'll send patch today

great :)

> 
> ----- Mail original -----
> De: "Dominik Csapak" <d.csapak at proxmox.com>
> À: "pve-devel" <pve-devel at pve.proxmox.com>
> Envoyé: Mercredi 8 Janvier 2020 09:59:15
> Objet: Re: [pve-devel] [PATCH proxmox-widget-toolkit 0/2] local network config improvements
> 
> On 1/8/20 4:31 AM, Alexandre Derumier wrote:
>> Following pve-common serie
>>
>> Alexandre Derumier (2):
>> networkedit: bond: add bond-primary field
>> networkedit: add mtu field
>>
>> node/NetworkEdit.js | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
> 
> looks mostly ok, (i'll write an extra mail with comments for 2/2)
> but if you add this, you also have to add the api functions for
> pmg[0] otherwise the next widget-toolkit update adds those fields
> that do not work there
> 
> i guess that it would suffice (for now) to simply make
> the same changes from pve-managers Network.pm in pmg-api
> 
> (longterm we should really refactor that...)
> 
> 
> 0: https://git.proxmox.com/?p=pmg-api.git;a=summary
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>