[pve-devel] [PATCH pve-manager 1/3] ifupdown1: bridgevlan: add bridge-vids list support

[Jorge Boncompte]

El 8/1/20 a las 4:31, Alexandre Derumier escribió:
> like ifupdown2, support multiple values
> 
> iface vmbr0
>    bridge-vids 2 4 5-10 70

	Before christmas i was testing the VLAN aware bridge functionality and
I found the hard way that mlx4 based network cards don't support more
than 128 VLAN's at the same time, or at least not with the default
configuration. I think that instead of adding ranges, the VID's should
be added dynamically when a VM starts and it should check for fails too
or else you could end up with a non working network card in the VM and
no indication of the fail.

	Best regards.

> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  network-hooks/bridgevlan | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/network-hooks/bridgevlan b/network-hooks/bridgevlan
> index ea043575..3965bfda 100755
> --- a/network-hooks/bridgevlan
> +++ b/network-hooks/bridgevlan
> @@ -41,7 +41,10 @@ do
>          # we allow vlan to pass through attached interface
>          if [ -n "$IF_BRIDGE_VIDS" ]
>  	then
> -            bridge vlan add dev $port vid $IF_BRIDGE_VIDS
> +            for VID in $IF_BRIDGE_VIDS
> +            do
> +                bridge vlan add dev $port vid $VID
> +            done
>  	else
>              bridge vlan add dev $port vid 2-4094
>          fi
>