[pve-devel] [PATCH proxmox-widget-toolkit 2/2] networkedit: add mtu field

Dominik Csapak d.csapak at proxmox.com
Wed Jan 8 10:02:51 CET 2020


comments inline

On 1/8/20 4:31 AM, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>   node/NetworkEdit.js | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/node/NetworkEdit.js b/node/NetworkEdit.js
> index ca0011f..eeb612c 100644
> --- a/node/NetworkEdit.js
> +++ b/node/NetworkEdit.js
> @@ -250,6 +250,15 @@ Ext.define('Proxmox.node.NetworkEdit', {
>   		    fieldLabel: gettext('Gateway') + ' (IPv6)',
>   		    vtype: 'IP6Address',
>   		    name: 'gateway6'
> +		},
> +		{
> +		    xtype: 'proxmoxintegerfield',
> +		    minValue: 1280,
> +		    maxValue: 65520,
> +		    deleteEmpty: !me.isCreate,
> +		    fieldLabel: gettext('MTU'),

i guess we should leave "MTU" untranslated, or is it
a phrase that is commonly translated? (in german it's not)

> +		    value: me.isCreate ? 'mtu' : undefined,

why do you set the value to the string 'mtu'?
it is an integerfield (so 'mtu' will trip the api verification)
and i we should not set it by default (simply omit the value)

> +		    name: 'mtu'
>   		}
>   	    );
>   	}
> 




More information about the pve-devel mailing list