[pve-devel] applied: [PATCH manager v2] Close #2262: Add noVNC scale setting

[Dominic Jäger]

On 9/26/19 4:53 PM, Thomas Lamprecht wrote:
> 
> Hmm, how about rename the button to "Clear" (or "Reset") only when we move it
> up? The association with what gets cleared should be then, well, clear.

Looks good to me. Then I'd to the same for the "Reset Layout" button.

> I'd like the button alignment more, the wide gap is not to border some
> but it could also just be used to explain that a bit more, e.g.:
> "Layout (grid width, sort orders, ...)"
> Not ideal, but you get the idea.

Would be OK for me as well.

>> Giving the two buttons the same size could be discussed. The material design recommends variable sizes [2].
> 
> Not to sure either, we currently have a mix, i.e., same width if << 75 px
> then variable.

I didn't know that. If we do the renaming to "Clear" or "Reset" only, we 
should get below 75px and could then have the aligned and same size version.


> When looking at the screenshot I find the missing padding between the
> xterm.js "Save" and "Reset" button also bothersome..
> 

Just to be sure: This was not something I changed. This happens to me on 
Chromium and Firefox with many (random?) zoom levels, but not with all.
> [2] https://material.io/components/buttons/#contained-button