[pve-devel] applied: [PATCH manager v2] Close #2262: Add noVNC scale setting

[Thomas Lamprecht]

On 9/26/19 1:02 PM, Dominic Jäger wrote:
> However, now the "Clear User name" button is the only one that is left below. Screenshots of the current state and my proposal are attached.
> 
> We could
> 
> 1.
> 1.a move the user name more to the left, such that the distance is the same as between the label and the radio field in the noVNC settings.
> 1.b and move the "Clear User name" button to the right, such that it is aligned with and has same width as the "Reset Layout" button. Apple, for example, uses the same width in the first screenshot in [0]. They explicitly suggest consistent widths (as we do it already) for text fields [1], so I just copied this for the buttons.
> 
> 2. use title-case: "Clear User name" => "Clear User Name" (as in [0])
> 

Hmm, how about rename the button to "Clear" (or "Reset") only when we move it
up? The association with what gets cleared should be then, well, clear.

I'd like the button alignment more, the wide gap is not to border some
but it could also just be used to explain that a bit more, e.g.:
"Layout (grid width, sort orders, ...)"
Not ideal, but you get the idea.

> 
> Giving the two buttons the same size could be discussed. The material design recommends variable sizes [2].

Not to sure either, we currently have a mix, i.e., same width if << 75 px
then variable.

When looking at the screenshot I find the missing padding between the
xterm.js "Save" and "Reset" button also bothersome.. 

> 
> 
> This all still leaves a giant gap between the "Layout:" label and its button, but the buttons would be a bit more consistent.
> 
> 
> [0] https://developer.apple.com/design/human-interface-guidelines/macos/buttons/push-buttons/
> [1] https://developer.apple.com/design/human-interface-guidelines/macos/fields-and-labels/text-fields/
> [2] https://material.io/components/buttons/#contained-button