[pve-devel] [PATCH qemu-server] fix #1934: add qemu fw_cfg variables via 'tags'

[Fabian Grünbichler]

On September 4, 2019 8:49 am, Dominik Csapak wrote:
> On 9/2/19 2:14 PM, Fabian Grünbichler wrote:
>> On August 23, 2019 2:03 pm, Dominik Csapak wrote:
>>> this add the 'tags' property to vms, which has the format:
>> 
>> why 'tags'? seems rather generic for what it does ;)
> 
> because the request in the bugreport was a more general one
> (users wanted to simply set some tags for the vm
> which are not in the description)
> 
> i just wanted to also use them besides simply having them in
> the config ;)

to me that sounds like rather unexpected behaviour. while there is some 
overlap between "tagging guest for categorization" and "exposing 
key-value pairs to guest", there are plenty of cases where the 
information from the former should not be exposed to the guest (e.g., an 
admin tagging annoying users with unflattering tag values ;)), and 
vice-versa, where having everything put into fw_cfg displayed as 
categorization tags is inconvenient/cluttering as well.

I am not opposed to a general 'tagging' feature at all (even if just for 
search/filtering and display purposes), but I'd keep it distinct from 
the fw_cfg stuff.