[pve-devel] [PATCH v2 qemu-server 03/12] Add CPUConfig file and migrate some CPU helpers

[Thomas Lamprecht]

On 10/2/19 10:24 AM, Stefan Reiter wrote:
> On 10/1/19 6:12 PM, Thomas Lamprecht wrote:
>> On 9/30/19 12:58 PM, Stefan Reiter wrote:
>>> The package will be used for custom CPU models as a SectionConfig, hence
>>> the name. For now we simply move some CPU related helper functions and
>>> declarations over from QemuServer to reduce clutter there.
>>
>> Single thing I'm not too sure is how "qemu_machine_feature_enabled" fit's
>> into the CPUConfig here..
>> AFAICT, this rather looks like and attempt to avoid a cyclic module
>> dependency?
> 
> Pretty much, yes. I don't think it looks *too* amiss.

Hmm, but it's just not CPU related itself at all..

> 
>>
>> Maybe we could also do a Machine module which then includes stuff like:
>> machine_type_is_q35
>> get_basic_machine_info
>>
>> But seems not really worth it... better ideas?
>>
> 
> No great ideas, but should I leave it this way for v3 or work something out?

Yeah, works for me, as long it stays in the same package moving it around
is almost no work, so we can change this relatively easily afterwards.

But please mention the "moved qemu_machine_feature_enabled to avoid
cyclic module dependencies" in the commit message.